gabriellefu commented on code in PR #23092:
URL: https://github.com/apache/kafka/pull/23092#discussion_r3750597472
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignorTest.java:
##########
@@ -926,7 +925,7 @@ public void
shouldHandleOddNumberOfClientsWithStandbyTasks() {
}
GroupAssignment result = assignor.assign(
- new GroupSpecImpl(members,
mkMap(mkEntry(NUM_STANDBY_REPLICAS_CONFIG,
String.valueOf(numStandbyReplicas)))),
+ new GroupSpecImpl(members, new
AssignmentConfigsImpl(numStandbyReplicas, List.of())),
Review Comment:
I have another pr is to avoid epoch bump when there's new config being
introduced. So I was thinking about implement the default part maybe after this
pr is merged? https://github.com/apache/kafka/pull/23088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
