gabriellefu commented on code in PR #23092:
URL: https://github.com/apache/kafka/pull/23092#discussion_r3750973606
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignorTest.java:
##########
@@ -926,7 +925,7 @@ public void
shouldHandleOddNumberOfClientsWithStandbyTasks() {
}
GroupAssignment result = assignor.assign(
- new GroupSpecImpl(members,
mkMap(mkEntry(NUM_STANDBY_REPLICAS_CONFIG,
String.valueOf(numStandbyReplicas)))),
+ new GroupSpecImpl(members, new
AssignmentConfigsImpl(numStandbyReplicas, List.of())),
Review Comment:
sounds good, i can do that. In the tests we can only pass the configs we
actually care about , otherwise they will use there default value, for replicas
is 0 and for tag is "".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
