anjy7 commented on PR #23136: URL: https://github.com/apache/kafka/pull/23136#issuecomment-5263641768
Btw `SharedRaftClientContext` doesn't strictly need to be an abstract class because we don't have any abstract methods. The upside is that it wont allow direct instantiation. I don't think we'll need to instantiate this anywhere as we'll need a Benchmark Context regardless to carry the `DrainableCounters`, JMH defaults and driving helpers like deliverAndAwaitResponse(...) etc. What do you think? Is keeping it abstract a good idea? @kevin-wu24 @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
