bbejeck commented on code in PR #23002:
URL: https://github.com/apache/kafka/pull/23002#discussion_r3771122278
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java:
##########
@@ -1831,6 +1832,93 @@ public void
testBuildingHeartbeatAssignmentSentWhenChanged(final MemberState mem
assertEquals(List.of(),
nonJoiningRequestDataWithChanges.warmupTasks());
}
+ private enum OwnedTaskRole { ACTIVE, STANDBY, WARMUP }
+
+ @ParameterizedTest
+ @EnumSource(OwnedTaskRole.class)
+ public void
testBuildingHeartbeatAllOwnedTaskListsSentWhenOnlyOneRoleChanges(final
OwnedTaskRole changingRole) {
+ // The broker reads the owned-task lists as a report of what the
member holds only when all three of them are
+ // non-null; if any is null it cannot tell that a task was released,
and the member effectively fails tp
Review Comment:
```suggestion
// non-null; if any is null it cannot tell that a task was released,
and the member effectively fails to
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
