bbejeck commented on code in PR #23144:
URL: https://github.com/apache/kafka/pull/23144#discussion_r3771759934
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -1074,6 +1081,18 @@ interface DBAccessor {
void reset();
void close();
+ /**
+ * Applies a batch of writes through {@code cfAccessor}, which owns
the column-family layout.
+ * The default applies the entries one at a time; accessors that can
write them as a single
+ * batch — or that must stage them instead of writing them — override
this.
+ */
+ default void putAll(final ColumnFamilyAccessor cfAccessor,
Review Comment:
It's inherited by the two test DBAccessors `InMemoryRocksDBAccessor`, and
`ThrowingOnOffsetsPutDBAccessor` but I can declare then as `abstract` implment
them in the test methods - fair enough to do in a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
