bbejeck commented on code in PR #23144:
URL: https://github.com/apache/kafka/pull/23144#discussion_r3785379558
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -1074,6 +1081,18 @@ interface DBAccessor {
void reset();
void close();
+ /**
+ * Applies a batch of writes through {@code cfAccessor}, which owns
the column-family layout.
+ * The default applies the entries one at a time; accessors that can
write them as a single
+ * batch — or that must stage them instead of writing them — override
this.
+ */
+ default void putAll(final ColumnFamilyAccessor cfAccessor,
Review Comment:
>Also wondering about the existing default impl of readOnly() below, which
does ignore its isolationLevel parameter, so wondering if this default impl
could even be correct to begin with? (Even if it's overwritten only by
TransactionalDBAccessor. Just curious to learn more, as I am not familiar with
the details of KIP-892 implemenation.
the default version of `readOnly` ignoring isolationLevel is correct because
a non-transactional accessor has no uncommitted state. So RC and RU are the
same view and returning `this` satisfies both.
Only the `TransactionalDBAccessor` needs the behavior and overrides it
RocksDBStore.java:1322)
[Comments from prior
review](https://github.com/apache/kafka/pull/22142#discussion_r3170704673)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
