gabriellefu commented on code in PR #23165:
URL: https://github.com/apache/kafka/pull/23165#discussion_r3786675013
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -9913,20 +9913,15 @@ TaskAssignor streamsGroupAssignor(String groupId,
boolean maybeLogWarning) {
}
/**
- * Get the assignor of the provided streams group.
+ * Get the assignment configs of the provided streams group.
*/
- private Map<String, String> streamsGroupAssignmentConfigs(String groupId) {
+ private AssignmentConfigsImpl streamsGroupAssignmentConfigs(String
groupId) {
Optional<GroupConfig> groupConfig =
groupConfigManager.groupConfig(groupId);
- final Integer numStandbyReplicas =
groupConfig.flatMap(GroupConfig::streamsNumStandbyReplicas)
+ final int numStandbyReplicas =
groupConfig.flatMap(GroupConfig::streamsNumStandbyReplicas)
.orElse(config.streamsGroupNumStandbyReplicas());
final List<String> rackAwareAssignmentTags =
groupConfig.flatMap(GroupConfig::streamsRackAwareAssignmentTags)
.orElse(config.streamsGroupRackAwareAssignmentTags());
Review Comment:
the GroupConfig::streamsRackAwareAssignmentTags and
config.streamsGroupRackAwareAssignmentTags() are both the trim() +
split("\s*,\s*", -1) version, so no guard for empty space needed in downstreams
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
