gabriellefu commented on code in PR #23165:
URL: https://github.com/apache/kafka/pull/23165#discussion_r3833406105
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6235,16 +6233,19 @@ public void replay(
streamsGroup.setStoredDescriptionTopologyEpoch(value.storedDescriptionTopologyEpoch());
streamsGroup.setFailedDescriptionTopologyEpoch(value.failedDescriptionTopologyEpoch());
- if (value.lastAssignmentConfigs() != null) {
- streamsGroup.setLastAssignmentConfigs(
+ // A record without configs (written before they were persisted,
or re-persisting such a state) leaves
+ // them unrecorded. The next heartbeat then compares the effective
configs against the defaults, so it
+ // only rebalances the group if any effective config differs from
its default.
+ if (value.lastAssignmentConfigs() == null ||
value.lastAssignmentConfigs().isEmpty()) {
+ streamsGroup.setLastAssignmentConfigs(Optional.empty());
Review Comment:
Agreed, I'd like to hear their take on this too before changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
