chia7712 commented on code in PR #22054:
URL: https://github.com/apache/kafka/pull/22054#discussion_r3794479227
##########
docker/jvm/Dockerfile:
##########
@@ -33,7 +33,7 @@ RUN set -eux ; \
apk upgrade ; \
apk add --no-cache bash procps-ng; \
mkdir opt/kafka; \
- if [ -n "$kafka_url" ]; then \
+ if [ -n "${kafka_url:-}" ]; then \
Review Comment:
Would you mind applying the same fix to the native image build as well? It
would be a great opportunity to backport `set -eux` to the native Dockerfile to
improve script robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
