chia7712 commented on code in PR #22054:
URL: https://github.com/apache/kafka/pull/22054#discussion_r3832512651
##########
docker/jvm/Dockerfile:
##########
@@ -33,7 +33,7 @@ RUN set -eux ; \
apk upgrade ; \
apk add --no-cache bash procps-ng; \
mkdir opt/kafka; \
- if [ -n "$kafka_url" ]; then \
+ if [ -n "${kafka_url:-}" ]; then \
Review Comment:
What do you think about using `ARG kafka_url=""` instead of
`"${kafka_url:-}"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
