chia7712 commented on code in PR #23170:
URL: https://github.com/apache/kafka/pull/23170#discussion_r3846720769
##########
docker/test/docker_sanity_test.py:
##########
@@ -209,44 +210,43 @@ def execute(self):
self.assertEqual(total_errors, [])
-class DockerSanityTestCombinedMode(DockerSanityTest):
+class TestDockerSanityCombinedMode(DockerSanityTest):
Review Comment:
Why do we need those change?
##########
docker/test/docker_sanity_test.py:
##########
@@ -209,44 +210,43 @@ def execute(self):
self.assertEqual(total_errors, [])
-class DockerSanityTestCombinedMode(DockerSanityTest):
+class TestDockerSanityCombinedMode(DockerSanityTest):
def setUp(self) -> None:
self.start_compose(f"{self.FIXTURES_DIR}/{constants.COMBINED_MODE_COMPOSE}")
def tearDown(self) -> None:
self.destroy_compose(f"{self.FIXTURES_DIR}/{constants.COMBINED_MODE_COMPOSE}")
def test_bed(self):
self.execute()
-class DockerSanityTestIsolatedMode(DockerSanityTest):
+class TestDockerSanityIsolatedMode(DockerSanityTest):
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
