chia7712 commented on code in PR #23170:
URL: https://github.com/apache/kafka/pull/23170#discussion_r3897489811
##########
docker/test/docker_sanity_test.py:
##########
@@ -231,22 +232,21 @@ def run_tests(image, mode, fixtures_dir,
container_runtime="docker"):
DockerSanityTest.MODE = mode
DockerSanityTest.CONTAINER_RUNTIME = container_runtime
- test_classes_to_run = []
- if mode == "jvm" or mode == "native":
- test_classes_to_run = [DockerSanityTestCombinedMode,
DockerSanityTestIsolatedMode]
-
- loader = unittest.TestLoader()
- suites_list = []
- for test_class in test_classes_to_run:
- suite = loader.loadTestsFromTestCase(test_class)
- suites_list.append(suite)
- combined_suite = unittest.TestSuite(suites_list)
- cur_directory = os.path.dirname(os.path.realpath(__file__))
- outfile = open(f"{cur_directory}/report_{mode}.html", "w")
- runner = HTMLTestRunner.HTMLTestRunner(
- stream=outfile,
- title=f'Test Report: Apache Kafka {mode.capitalize()} Docker
Image',
- description='This demonstrates the report output.'
- )
- result = runner.run(combined_suite)
- return (result.failure_count, result.error_count)
+ if report_path is None:
Review Comment:
Have you defined `report_path`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
