harmadasg commented on code in PR #23199:
URL: https://github.com/apache/kafka/pull/23199#discussion_r3864676592
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorMetricsTest.java:
##########
@@ -191,21 +189,22 @@ public void
shouldRecordMetricsWithBuiltInMetricsVersionLatest() {
{
final Map<MetricName, ? extends Metric> metrics =
context.metrics().metrics();
- verifyMetric(metrics, evictionRateMetric, greaterThan(0.0));
- verifyMetric(metrics, evictionTotalMetric, is(1.0));
- verifyMetric(metrics, bufferSizeAvgMetric, is(41.0));
- verifyMetric(metrics, bufferSizeMaxMetric, is(82.0));
- verifyMetric(metrics, bufferCountAvgMetric, is(1.0));
- verifyMetric(metrics, bufferCountMaxMetric, is(2.0));
+ assertEquals(evictionRateMetric.description(),
metrics.get(evictionRateMetric).metricName().description());
Review Comment:
Thanks I missed the `verifyMetric` call from the above block on the very
same metric, fixed it in
[68c1948](https://github.com/apache/kafka/pull/23199/commits/68c19487b4071c4b0b80146d54ebf6f1e07f6fae)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
