chia7712 commented on code in PR #23199:
URL: https://github.com/apache/kafka/pull/23199#discussion_r3872254821
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorTest.java:
##########
@@ -424,12 +420,11 @@ public void
suppressShouldShutDownWhenOverRecordCapacity() {
context.setRecordMetadata("", 0, 1L);
context.setTimestamp(timestamp);
- try {
+ final Throwable exception = assertThrows(StreamsException.class, () ->
{
harness.processor.process(new Record<>("dummyKey", value,
timestamp));
fail("expected an exception");
Review Comment:
Please remove `fail("expected an exception");`
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorTest.java:
##########
@@ -448,39 +443,18 @@ public void suppressShouldShutDownWhenOverByteCapacity() {
context.setRecordMetadata("", 0, 1L);
context.setTimestamp(1L);
- try {
+ final Throwable exception = assertThrows(StreamsException.class, () ->
{
harness.processor.process(new Record<>("dummyKey", value,
timestamp));
fail("expected an exception");
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
