chia7712 commented on code in PR #21943:
URL: https://github.com/apache/kafka/pull/21943#discussion_r3918828693
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -45,7 +45,7 @@
*/
public class AbstractConfig {
- private static final Logger log =
LoggerFactory.getLogger(AbstractConfig.class);
+ public static final Logger log =
LoggerFactory.getLogger(AbstractConfig.class);
Review Comment:
> it to protected
This is a bit of a grey area. We haven't reached consensus on whether
protected members count as public API when the public class is meant to be
extended. To sidestep that, I'd prefer that AbstractKafkaConfig has its own
LOGGER
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
