chia7712 commented on code in PR #21943:
URL: https://github.com/apache/kafka/pull/21943#discussion_r3952880118
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -174,48 +170,10 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _], enforceProv
private val _shareCoordinatorConfig = new ShareCoordinatorConfig(this)
def shareCoordinatorConfig: ShareCoordinatorConfig = _shareCoordinatorConfig
- /** ********* General Configuration ***********/
- val brokerSessionTimeoutMs: Int =
getInt(KRaftConfigs.BROKER_SESSION_TIMEOUT_MS_CONFIG)
- val controllerPerformanceSamplePeriodMs: Long =
getLong(KRaftConfigs.CONTROLLER_PERFORMANCE_SAMPLE_PERIOD_MS)
- val controllerPerformanceAlwaysLogThresholdMs: Long =
getLong(KRaftConfigs.CONTROLLER_PERFORMANCE_ALWAYS_LOG_THRESHOLD_MS)
val controllerMaxRecordsPerBatch: Int =
getInt(KRaftConfigs.CONTROLLER_MAX_RECORDS_PER_BATCH_CONFIG)
- private def parseProcessRoles(): Set[ProcessRole] = {
- val roles = getList(KRaftConfigs.PROCESS_ROLES_CONFIG).asScala.map {
- case "broker" => ProcessRole.BrokerRole
- case "controller" => ProcessRole.ControllerRole
- case role => throw new ConfigException(s"Unknown process role '$role'" +
- " (only 'broker' and 'controller' are allowed roles)")
- }
- roles.toSet
- }
-
def isKRaftCombinedMode: Boolean = {
Review Comment:
This method is used by testing only, so maybe we could just remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
