chia7712 commented on code in PR #22721:
URL: https://github.com/apache/kafka/pull/22721#discussion_r3918957218
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -89,10 +89,19 @@ public abstract class AbstractKafkaConfig extends
AbstractConfig {
AddPartitionsToTxnConfig.CONFIG_DEF
));
+ private volatile QuotaConfig quotaConfig;
Review Comment:
The cost of creating `QuotaConfig` is low, since `AbstractConfig.getInt`
just returns the already-parsed value. We could remove `quotaConfig()` and have
callers construct `new QuotaConfig(config)` where they need it. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
