regarmukesh3g commented on PR #23324: URL: https://github.com/apache/kafka/pull/23324#issuecomment-5585060550
Thanks for the review @see-quick. To confirm your guess: the constructor was introduced in #17763 (KAFKA-17949) with `Objects.requireNonNull` on `type` but not on `groupState`, so it does look like a simple oversight rather than a deliberate asymmetry. `toString()` already dereferences `groupState` unconditionally via `groupState.map(...)`, so a null there would have failed later with a less obvious `NullPointerException`. CI is green here (JUnit Java 17 and Java 25 both pass) and the change is approved. @chia7712 @AndrewJSchofield since you both reviewed the original #17763, would one of you be willing to take a look and merge if it seems reasonable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
