chia7712 commented on code in PR #23324:
URL: https://github.com/apache/kafka/pull/23324#discussion_r3984007950
##########
clients/src/main/java/org/apache/kafka/clients/admin/GroupListing.java:
##########
@@ -45,8 +45,8 @@ public class GroupListing {
public GroupListing(String groupId, Optional<GroupType> type, String
protocol, Optional<GroupState> groupState) {
this.groupId = groupId;
Review Comment:
Our production code never passes `null` for any of those arguments. Since
this PR is just guarding against null, why not apply the same rule to `groupId
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
