clolov commented on code in PR #21943:
URL: https://github.com/apache/kafka/pull/21943#discussion_r3977945904
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -90,9 +99,12 @@ public abstract class AbstractKafkaConfig extends
AbstractConfig {
));
private volatile QuotaConfig quotaConfig;
+ private volatile Set<ProcessRole> processRoles;
Review Comment:
As part of this, I learned something new today. Spotbugs ought to catch
things like this, but it doesn't in abstract classes. I find this a bit
interesting, because abstract or not-abstract shouldn't matter for a private
field, but I guess it does. Thanks for spotting this! The new revision corrects
it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
