AndrewJSchofield commented on code in PR #23499:
URL: https://github.com/apache/kafka/pull/23499#discussion_r4039867183
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetchCollector.java:
##########
@@ -118,7 +118,10 @@ public ShareFetch<K, V> collect(final ShareFetchBuffer
fetchBuffer) {
}
}
}
- } catch (KafkaException e) {
+ } catch (RuntimeException e) {
Review Comment:
Because if there is an unhandled exception which is not a KafkaException,
and there are already records waiting to be delivered, they are left in limbo.
The situation where this could happen is if we get an unexpected error code
from Kafka in `ShareFetchCollector.handleInitializeErrors()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
