AndrewJSchofield commented on code in PR #23499:
URL: https://github.com/apache/kafka/pull/23499#discussion_r4045391556
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetchCollector.java:
##########
@@ -118,7 +118,10 @@ public ShareFetch<K, V> collect(final ShareFetchBuffer
fetchBuffer) {
}
}
}
- } catch (KafkaException e) {
+ } catch (RuntimeException e) {
Review Comment:
I've changed my mind here. I'll change
`ShareFetchCollector.handleInitializeErrors()` so that it only throws
`KafkaException`. On reflection, I prefer this way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
