suzhiking commented on PR #22586: URL: https://github.com/apache/kafka/pull/22586#issuecomment-5784072506
@lucasbru addressing each of comments: 1. `consumer.group.protocol` is dropped without warning: Copilot is right, but it's actually a pre-existing bug (not introduced by this PR). I fixed it by reordering the merge and drop so that only `group.protocol` is dropped. 2. made the warning more general instead of saying it's streams' default value. 3. I do believe forcing `main`, `restore`, `global`'s `consumer.isolation.level` is the correct fix as it's documented in https://kafka.apache.org/43/streams/developer-guide/config-streams/#parameters-controlled-by-kafka-streams as a controlled config. Maybe @bbejeck could confirm if it's correct? Also addressed the rebase conflict: 1. trunk introduced a new `bootstrap.resolve.timeout.ms` config and is enforced by streams on the consumer, producer, and admin clients, set to `0`. So I added a `CONTROLLED_CLIENT_CONFIGS` and add it to each of these 3 clients' enforcement path. 2. I also updated the official docs page and the javadoc to include all the controlled configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
