bbejeck commented on PR #22586: URL: https://github.com/apache/kafka/pull/22586#issuecomment-5796073958
> @suzhiking - I think both points made by copilot are valid and, while not must-fix are should-fix. > > The one thing I was worried about is something like `restore.consumer.isolation.level=read_uncommitted`. It was allowed before under EOSv2 - not sure if anybody would do it, but this change would break it. @bbejeck wdyt, is this a concern? It for sure would be just a small minority doing such a thing, but I wonder if we have seen this? Yeah I agree, I'm can't think of a reason why this would be done. I don't know myself of a case where users were using `read_uncommitted`with EOS enabled. I quess as long as we document this well it's OK to go forward. Overall it makes sense to me to enforce this for the restore consumer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
