lucliu1108 commented on code in PR #23566:
URL: https://github.com/apache/kafka/pull/23566#discussion_r4100085103
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1355,7 +1089,7 @@ private CompletableFuture<Void>
cleanupTopologyBeforeConversion(
failJoinRetriably(request, responseFuture);
return CompletableFuture.completedFuture(null);
}
- return markTopologyUncertainAsync(tp, request.groupId(), false)
+ return
streamsGroupTopologyDescriptionManager.markTopologyUncertain(request.groupId(),
false)
Review Comment:
Fix: Created a new
`StreamsGroupTopologyDescription#cleanupTopologyBeforeConversion` method to
gather all those steps in, and return a boolean to indicate if the cleanup
succeeded. If not, retry in GC service.
Also marked those methods private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
