chia7712 commented on code in PR #23583:
URL: https://github.com/apache/kafka/pull/23583#discussion_r4111917127
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -681,6 +681,12 @@ private boolean startTask(
connectorStatusMetricsGroup.recordTaskAdded(id);
final ClassLoader connectorLoader;
+ Converter keyConverter = null;
Review Comment:
This style is hard on the eyes. Would you mind adding a helper method to
create the converter? The helper should wrap the converter with a Plugin
directly and take care of closing the raw converter if the wrap fails, so
callers only ever need to close the Plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
