lucliu1108 commented on code in PR #23583:
URL: https://github.com/apache/kafka/pull/23583#discussion_r4112285097
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -681,6 +681,12 @@ private boolean startTask(
connectorStatusMetricsGroup.recordTaskAdded(id);
final ClassLoader connectorLoader;
+ Converter keyConverter = null;
Review Comment:
Created 2 helper methods: one for key/value converter plugin and another for
header converter plugin. It is possible to do just one using supplier but the
`newConverter` code will become chunky and hard to read, so I keep them as 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
