1fanwang commented on code in PR #22155:
URL: https://github.com/apache/kafka/pull/22155#discussion_r4140560758
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##########
@@ -220,7 +220,7 @@ public void process(final Record<KIn, VIn> record) {
internalProcessorContext.recordContext().topic(),
internalProcessorContext.recordContext().partition(),
internalProcessorContext.recordContext().offset(),
- internalProcessorContext.recordContext().headers(),
+ internalProcessorContext.recordContext().sourceRawHeaders(),
Review Comment:
Updated `RecordCollectorImpl#errorHandlerContext` to pass
`context.recordContext().sourceRawHeaders()`, and added
`shouldHaveSourceRawHeadersDuringExceptionInSerialization` in
`RecordCollectorTest` in 3ed47aaeff.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorRecordContext.java:
##########
@@ -107,6 +114,10 @@ public byte[] sourceRawValue() {
return sourceRawValue;
}
+ public Headers sourceRawHeaders() {
+ return sourceRawHeaders == null ? headers : sourceRawHeaders;
Review Comment:
Added javadoc documenting the null-to-live-headers fallback in
`ProcessorRecordContext#sourceRawHeaders` in 3ed47aaeff.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java:
##########
@@ -262,7 +262,8 @@ public <K, V> void forward(final Record<K, V> record, final
String childName) {
recordContext.topic(),
record.headers(),
recordContext.sourceRawKey(),
- recordContext.sourceRawValue()
+ recordContext.sourceRawValue(),
+ recordContext.sourceRawHeaders()
Review Comment:
I added
`shouldExposeOriginalHeadersWhenForwardingWithChangedHeadersFailsDownstream` in
`ProcessingExceptionHandlerIntegrationTest` in 3ed47aaeff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
