dajac commented on PR #22593: URL: https://github.com/apache/kafka/pull/22593#issuecomment-5953403868
@danoSF Thanks for the patch! I am not really comfortable with this change because it breaks the encapsulation of the classic protocol. If we start deserializing embedded protocols, where do we stop? It can get messy pretty quickly if we start on this path. Another thing to be careful with is that a client may use `consumer` name for the embedded protocol without using the same as ours. We have seen cases like this. I would rather prefer to get users on KIP-848 as the new consumer protocol address all these flaws in the classic protocol. At this point, if a user is impacted by this, upgrading seems to be a reasonable path. What do you guys think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
