lianetm commented on PR #22593: URL: https://github.com/apache/kafka/pull/22593#issuecomment-6224804386
Hey all! Chia agree that the embedded subscription is already being parsed, but I do see the "where do we stop" challenge too (actually in 2 ways, where to stop trying to interpret the embedded protocol to take decisions, and where to stop fixing related issues in the same area of the classic, that are greatly improved in the new protocol) This PR fixes one trigger of the "static member stale assignment" issue (and needs to parse the embedded subscription to fix). But then we would still have the same wrong behaviour but under other triggers (metadata change, assignment dropped), and to fix we would need to parse some other part of the embedded protocol (the assignment). E.g. this 2 issues [KAFKA-12169](https://issues.apache.org/jira/browse/KAFKA-12169) and [KAFKA-10078](https://issues.apache.org/jira/browse/KAFKA-10078). Would we want to look at those too, same symptom, different fix/parsing (actually trickier fixes needing protocol parsing vs metadata) Also to consider KIP-1274, that has the classic protocol on a deprecation timeline already (we can/will still fix, but cnsidering this). Just my 2 cents, open to hearing back :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
