chia7712 commented on code in PR #23684: URL: https://github.com/apache/kafka/pull/23684#discussion_r4174480897
########## tools/src/main/java/org/apache/kafka/tools/consumer/ConsumerGroupMessageFormatter.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools.consumer; + +import org.apache.kafka.common.protocol.ApiMessage; +import org.apache.kafka.coordinator.group.GroupCoordinatorRecordSerde; +import org.apache.kafka.coordinator.group.generated.CoordinatorRecordJsonConverters; +import org.apache.kafka.coordinator.group.generated.CoordinatorRecordType; + +import com.fasterxml.jackson.databind.JsonNode; + +import java.util.Set; + +/** + * Formatter for use with tools such as console consumer: Consumer should also set exclude.internal.topics to false. + * Formats the records on the __consumer_offsets topic which pertain to consumer groups using the consumer protocol. + */ +public class ConsumerGroupMessageFormatter extends CoordinatorRecordMessageFormatter { Review Comment: I just realized that we don't have any docs for those formatters. I opened https://issues.apache.org/jira/browse/KAFKA-21206 as a follow-up. ########## tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java: ########## @@ -447,6 +453,46 @@ public void testGroupMetadataMessageFormatterWithConsumerGroupProtocol(ClusterIn } } + @ClusterTest(serverProperties = { Review Comment: Running both modes is a bit wasteful, but keeping it consistent with the other tests is fine too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
