lianetm commented on code in PR #23714:
URL: https://github.com/apache/kafka/pull/23714#discussion_r4187231304
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -184,6 +184,11 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
return new
NetworkClientDelegate.PollResult(heartbeatRequestState.heartbeatIntervalMs(),
Collections.singletonList(leaveHeartbeat));
}
+ if (membershipManager().state() == MemberState.LEAVING &&
shouldSkipLeaveHeartbeat()) {
Review Comment:
uhmm I guess this means that the `REMAIN_IN_GROUP` close option was not
working at all?? (not only when racing with poll timer expired, but also on any
regular close that passed remain true, is my understanding correct?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
