brandboat commented on code in PR #23687:
URL: https://github.com/apache/kafka/pull/23687#discussion_r4197072817
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -114,7 +114,8 @@ public abstract class AbstractHeartbeatRequestManager<R
extends AbstractResponse
this.maxPollIntervalMs =
config.getInt(CommonClientConfigs.MAX_POLL_INTERVAL_MS_CONFIG);
long retryBackoffMs =
config.getLong(ConsumerConfig.RETRY_BACKOFF_MS_CONFIG);
long retryBackoffMaxMs =
config.getLong(ConsumerConfig.RETRY_BACKOFF_MAX_MS_CONFIG);
- this.heartbeatRequestState = new HeartbeatRequestState(logContext,
time, 0, retryBackoffMs,
+ int requestTimeoutMs =
config.getInt(ConsumerConfig.REQUEST_TIMEOUT_MS_CONFIG);
Review Comment:
Yes, users can set `request.timeout.ms` to `0`, but doing so would cause
broader problems, many requests would time out immediately, not just causing
the busy loop here.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -413,10 +413,11 @@ public StreamsGroupHeartbeatRequestManager(final
LogContext logContext,
long retryBackoffMs =
config.getLong(ConsumerConfig.RETRY_BACKOFF_MS_CONFIG);
long retryBackoffMaxMs =
config.getLong(ConsumerConfig.RETRY_BACKOFF_MAX_MS_CONFIG);
this.heartbeatState = new HeartbeatState(streamsRebalanceData,
membershipManager, maxPollIntervalMs, time);
+ int requestTimeout =
config.getInt(ConsumerConfig.REQUEST_TIMEOUT_MS_CONFIG);
Review Comment:
Yes, users can set request.timeout.ms to 0, but doing so would cause broader
problems, many requests would time out immediately, not just causing the busy
loop here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
