sunm2n commented on PR #23602:
URL: https://github.com/apache/kafka/pull/23602#issuecomment-6031527556
I fixed the same issue in SuppressionIntegrationTest (#23655), so I
checked this against the pitfalls I ran into there:
- The only names derived from the application id in this class are the two
changelog topics, and both are now built from appId
- Each test runs a single KafkaStreams instance in try-with-resources, so
the previous invocation's member expiring was the only wait
- Creating a fresh Properties per invocation also keeps the headers store
format from leaking into the next parameterized case
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
