psiby commented on code in PR #23268:
URL: https://github.com/apache/kafka/pull/23268#discussion_r4229205438
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -1418,7 +1439,13 @@ void modifySinkConnectorOffsets(String connName,
Connector connector, Map<String
try {
Map<TopicPartition, Long> offsetsToWrite;
- if (isReset) {
+ // Both a reset and a replace start by tombstoning every
offset the consumer group currently has;
+ // a replace then overlays the requested offsets on top of
those tombstones.
+ if (isReset || replaceAllOffsets) {
+ String modification = isReset ? "resetting" :
"replacing";
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
