psiby commented on code in PR #23268:
URL: https://github.com/apache/kafka/pull/23268#discussion_r4229216581
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##########
@@ -266,6 +270,56 @@ public void testCreateConnectorWithStoppedInitialState()
throws Exception {
verify(loaderSwap).close();
}
+ @Test
Review Comment:
Added two error path tests:
`testCreateConnectorWithInitialOffsetsOffsetsWriteFails` (the connector is
never created) and `testCreateConnectorWithInitialOffsetsConfigWriteFails` (the
offsets are wiped back out).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
