see-quick commented on PR #23560: URL: https://github.com/apache/kafka/pull/23560#issuecomment-6097149926
> > the generated Docker Official Image source is > > byte-identical to trunk. > > Is this description still right? The `command -v java` line ends up in the generated Dockerfile too, so it is no longer identical to trunk. > > Otherwise LGTM. I ran the command: > > ``` > python3 docker_build_test.py kafka/test \ > --image-tag=4.5.0-SNAPSHOT \ > --image-type=jvm \ > --base-image=docker.io/library/eclipse-temurin:21-jre-alpine \ > --kafka-archive=/home/chia7712/project/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT.tgz -b > ``` > > and it works well. True, updated PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
