psiby commented on code in PR #23268:
URL: https://github.com/apache/kafka/pull/23268#discussion_r4246842462
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/CreateConnectorRequest.java:
##########
@@ -21,18 +21,54 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.List;
import java.util.Locale;
import java.util.Map;
public record CreateConnectorRequest(
@JsonProperty("name") String name,
@JsonProperty("config") Map<String, String> config,
- @JsonProperty("initial_state") InitialState initialState
+ @JsonProperty("initial_state") InitialState initialState,
+ @JsonProperty("initial_offsets") List<ConnectorOffset> initialOffsets
Review Comment:
This was a great catch! I think we definitely should have done that. Fixed
in #23783.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
