AndrewJSchofield commented on code in PR #23651:
URL: https://github.com/apache/kafka/pull/23651#discussion_r4247051430


##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -350,13 +350,25 @@ public KafkaProducer(Properties properties, Serializer<K> 
keySerializer, Seriali
         this(Utils.propsToMap(properties), keySerializer, valueSerializer);
     }
 
+    KafkaProducer(ProducerConfig config,
+                  Serializer<K> keySerializer,
+                  Serializer<V> valueSerializer,
+                  ProducerMetadata metadata,
+                  KafkaClient kafkaClient,
+                  ProducerInterceptors<K, V> interceptors,
+                  ApiVersions apiVersions,
+                  Time time) {
+        this(config, keySerializer, valueSerializer, metadata, kafkaClient, 
Uuid.randomUuid(), interceptors, apiVersions, time);

Review Comment:
   This doesn't seem useful. We know that this random UUID will not match 
whatever the `kafkaClient` already has.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to