alanlau28 commented on code in PR #23651:
URL: https://github.com/apache/kafka/pull/23651#discussion_r4260046476
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -350,13 +350,25 @@ public KafkaProducer(Properties properties, Serializer<K>
keySerializer, Seriali
this(Utils.propsToMap(properties), keySerializer, valueSerializer);
}
+ KafkaProducer(ProducerConfig config,
+ Serializer<K> keySerializer,
+ Serializer<V> valueSerializer,
+ ProducerMetadata metadata,
+ KafkaClient kafkaClient,
+ ProducerInterceptors<K, V> interceptors,
+ ApiVersions apiVersions,
+ Time time) {
+ this(config, keySerializer, valueSerializer, metadata, kafkaClient,
Uuid.randomUuid(), interceptors, apiVersions, time);
Review Comment:
I missed two tests that should pass `clientInstanceId`, pushed an update for
those tests. Every producer test that creates a `MockClient` now uses its ID.
This constructor is for producers that create their own ID, which is the
production path. I added a clientInstanceId parameter to the old constructor,
so this constructor is needed as it creates and passes a random ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
