dajac commented on code in PR #23732: URL: https://github.com/apache/kafka/pull/23732#discussion_r4248820224
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/uniform2/CurrentAssignment.java: ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.assignor.uniform2; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.api.assignor.GroupSpec; +import org.apache.kafka.coordinator.group.assignor.uniform2.util.IntList; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +/** + * The current assignment of a group: the owner of every partition. + * + * <p>A member owns a partition when it holds it, subscribes to its topic, and the partition + * exists. Everything else the members hold is stale: the partitions of topics they do not + * subscribe to or which no longer exist, the partitions beyond the partition count of their topic, + * and the empty sets of partitions. Stale partitions are dropped silently, and the members holding + * some get a new map. As the coordinator guarantees, a partition is held by at most one member. + */ +final class CurrentAssignment { + /** + * Per member, the partitions it holds, as given by the spec. + */ + private final List<Map<Uuid, Set<Integer>>> assignments; + + /** + * Per member, whether it holds stale partitions, and thus needs a new map. + */ + private final boolean[] holdsStalePartitions; + + /** + * Per topic, the owner of every partition, or -1; null while no partition of the topic has an + * owner. Review Comment: It is for both perf and mem usage. It regresses without. I lean towards keeping it even if it is a bit ackward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
