dajac commented on code in PR #23732: URL: https://github.com/apache/kafka/pull/23732#discussion_r4248959811
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/uniform2/GroupModel.java: ########## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.assignor.uniform2; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.api.assignor.GroupSpec; +import org.apache.kafka.coordinator.group.api.assignor.SubscribedTopicDescriber; +import org.apache.kafka.coordinator.group.api.assignor.SubscriptionType; +import org.apache.kafka.coordinator.group.assignor.uniform2.util.IntList; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * The members, the subscribed topics and the cohorts of a group, numbered by small integers. + * + * <p>Members are numbered in member id order and topics in topic id order, so that every + * decision taken on these numbers depends on the content of the input only, never on the + * iteration order of the collections of the spec. A cohort is a set of members having the same + * subscription; cohorts are numbered in the order of their first member. The topics are those Review Comment: Both. A cohort is the set of members with the same subscription, and the assignor works per distinct subscription wherever it can instead of per member. All the algorithms that I came up with Claude had this notion. I am pretty convinced that it is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
