dajac commented on PR #23732:
URL: https://github.com/apache/kafka/pull/23732#issuecomment-6126185426
> * Claude sometimes draws weird class/abstraction boundaries.
Yeah, I agree.
> * Claude's made a lot of small decisions that add up to a lot more code.
I made some of those too :).
> * Generally I'm not a fan of the Claude 5 series inventing new terminology
for things, especially when there is existing terminology in use. It took me a
while to realize that `Shares` is just quotas, which is a concept we already
have in the uniform homogeneous assignor.
Agreed. We should stick to existing names as much as possible. The `Shares`
term was actually from me but `Quotas` sounds better.
> * We are ditching the goal of balanced total partition counts for the
heterogeneous case. By that I mean that a subscription topology like {member 0
subscribes to topics 1 to 10 and member i subscribes to topic i, for i=1..10,
where each topic has 10 partitions} would give member 0 50 partitions and the
rest 5 each. So I wonder if the `ShareBalancer` step is worth keeping at all.
In your example, it is indeed useless but there are other cases where it is
useful. We can discuss those when we get to that part. Using it or not is
actually one line change in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
