chia7712 commented on code in PR #23715:
URL: https://github.com/apache/kafka/pull/23715#discussion_r4246386618
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##########
@@ -86,6 +86,8 @@
@ClusterConfigProperty(key = GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG,
value = "1000"),
@ClusterConfigProperty(key =
CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG, value = "500"),
@ClusterConfigProperty(key =
CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG, value = "500"),
+ @ClusterConfigProperty(key = "log.initial.task.delay.ms", value =
"100"),
Review Comment:
Personally, I don’t like to add those specific configurations since they
look like something magic. Perhaps this PR can refactor that code as well.
1. ClusterInstance#deleteTopic should wait for metadata sync only
2. the logic of waiting disk sync could be moved to DeleteTopicTest. It is
the only user
3. remove all those mysterious configurations from other test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
