stantheman0128 commented on code in PR #23113:
URL: https://github.com/apache/kafka/pull/23113#discussion_r4259891911
##########
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##########
@@ -628,7 +628,7 @@ boolean canMoveStandbyTask(final KafkaStreamsState source,
/**
*
- * @return the traffic cost of assigning this {@param task} to the client
{@param streamsState}.
+ * @return the traffic cost of assigning this {@code task} to the client
{@code streamsState}.
Review Comment:
Right, the matching parameters are `topicPartitions` and `clientRack`. Fixed
in 6b98cf9, together with `validateTopicPartitionRack`, whose doc called the
field `racksForPartition` a parameter.
251ce9f fixes more doc errors in the same two files: three `@{code
trafficCost}` typos, and the `@return` of `canPerformRackAwareOptimization`,
which said the opposite of what the method returns. I can move that commit to a
separate PR if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
