cheeeee commented on PR #23445:
URL: https://github.com/apache/kafka/pull/23445#issuecomment-6160507943

   Thanks for the review, Jun. The failure now reaches `LogDirFailureChannel`: 
`LocalLog.read` gives the records it
   returns a handler that calls `maybeAddOfflineLogDir`, and `writeTo` notifies 
it before throwing
   `KafkaStorageException`, the same way `LocalLog.maybeHandleIOException` 
handles any other `IOException`. The
   criterion is the same as there: an `IOException` from reading the open 
channel is a storage failure, while an end of
   file, a read without progress and a closed channel are inconclusive. The 
whole region is re-read now, only on the
   error path, since on some platforms the transfer can fail past its first 
byte. On accuracy: the detection can only
   be as accurate as what the JVM reports; the description lists the cases at 
that level and how each is handled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to