cheeeee commented on code in PR #23445:
URL: https://github.com/apache/kafka/pull/23445#discussion_r4286763405


##########
clients/src/main/java/org/apache/kafka/common/record/internal/FileRecords.java:
##########
@@ -146,7 +157,25 @@ public FileRecords slice(int position, int size) {
         int availableBytes = availableBytes(position, size);
         int startPosition = this.start + position;
 
-        return new FileRecords(file, channel, startPosition, startPosition + 
availableBytes);
+        return new FileRecords(file, channel, startPosition, startPosition + 
availableBytes, readFailureHandler);
+    }
+
+    /**
+     * Return a slice covering the current records of this instance whose 
{@link #writeTo} reports a failed read of

Review Comment:
   It returned a slice frozen at the current size; it now rejects a non-slice 
with `IllegalStateException`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to