chia7712 commented on code in PR #23800:
URL: https://github.com/apache/kafka/pull/23800#discussion_r4282032814
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DeleteTopicTest.java:
##########
@@ -58,9 +58,7 @@
brokers = 3,
serverProperties = {
@ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
- @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1"),
- @ClusterConfigProperty(key = "log.initial.task.delay.ms", value =
"100"),
- @ClusterConfigProperty(key = "log.segment.delete.delay.ms", value =
"1000")
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1")
Review Comment:
This means there are no test cases covering the file deletion, right? I
didn’t grep other files, but it would be great if the following scenarios could
be covered.
1 the files will be deleted from disk. testCreateAndDeleteTopic should
include that
2. the broker restart will drop all -delete files.
This could be a follow-up I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
