brandboat commented on code in PR #23800:
URL: https://github.com/apache/kafka/pull/23800#discussion_r4283757893
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DeleteTopicTest.java:
##########
@@ -58,9 +58,7 @@
brokers = 3,
serverProperties = {
@ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
- @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1"),
- @ClusterConfigProperty(key = "log.initial.task.delay.ms", value =
"100"),
- @ClusterConfigProperty(key = "log.segment.delete.delay.ms", value =
"1000")
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1")
Review Comment:
Thanks for the heads-up. Some of those test cases are already covered:
> 1 the files will be deleted from disk. testCreateAndDeleteTopic should
include that
This is covered in `ProducerSendWhileDeletionTest#verifyTopicDeletion`
https://github.com/apache/kafka/blob/62f0fef0e81a8e24f6d174f9cf4b640620696e7c/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerSendWhileDeletionTest.java#L272-L275
> 2. the broker restart will drop all -delete files.
This one isn't, I'll file a PR for it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
