jolshan commented on code in PR #23831:
URL: https://github.com/apache/kafka/pull/23831#discussion_r4296901258
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##########
@@ -735,6 +735,40 @@ class TransactionStateManagerTest {
verifyWritesTxnMarkersInPrepareState(TransactionState.PREPARE_ABORT)
}
+ @Test
+ def shouldCompleteEmptyPrepareCommitOnLoad(): Unit = {
+ // With transaction V2, committing a transaction with no partitions writes
PrepareCommit with no partitions.
+ // On load, it must be completed the same way as an empty PrepareAbort.
Review Comment:
Do we have such a test for the prepare abort? I didn't quite understand what
this test was doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
